Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 994353003: Hide call to removeDisplayTree in CueTimeline (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Hide call to removeDisplayTree in CueTimeline TextTrack::setMode explicitly cleans out the display trees of its cues. Move this into a new method - hideCues() - on CueTimeline and call that instead. This keeps the manipulation of the display representation in a single place. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M Source/core/html/track/CueTimeline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/track/CueTimeline.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 9 months ago (2015-03-11 14:40:31 UTC) #2
philipj_slow
lgtm
5 years, 9 months ago (2015-03-12 03:31:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994353003/1
5 years, 9 months ago (2015-03-12 03:32:06 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 03:35:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191748

Powered by Google App Engine
This is Rietveld 408576698