Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 994313005: Make WebView shell handle generic motion events. (Closed)

Created:
5 years, 9 months ago by ksk
Modified:
5 years, 9 months ago
Reviewers:
jdduke (slow), boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebView shell handle generic motion events. This is needed to support mouse wheel scroll in android_webview_shell. BUG=468806 Committed: https://crrev.com/0c5216571a19acf485517630cacd5746915c9435 Cr-Commit-Position: refs/heads/master@{#321779}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jdduke (slow)
lgtm (modulo the requested change), +boliu for owner review https://codereview.chromium.org/994313005/diff/1/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java File android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java (right): https://codereview.chromium.org/994313005/diff/1/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java#newcode387 android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:387: ...
5 years, 9 months ago (2015-03-19 16:48:32 UTC) #2
boliu
lgtm
5 years, 9 months ago (2015-03-19 17:01:24 UTC) #3
ksk
https://codereview.chromium.org/994313005/diff/1/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java File android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java (right): https://codereview.chromium.org/994313005/diff/1/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java#newcode387 android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java:387: public boolean onGenericMotionEvent(MotionEvent ev) { On 2015/03/19 16:48:32, jdduke ...
5 years, 9 months ago (2015-03-23 08:29:14 UTC) #4
boliu
still lgtm
5 years, 9 months ago (2015-03-23 14:04:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994313005/20001
5 years, 9 months ago (2015-03-23 15:06:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 15:39:20 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:40:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c5216571a19acf485517630cacd5746915c9435
Cr-Commit-Position: refs/heads/master@{#321779}

Powered by Google App Engine
This is Rietveld 408576698