Show hovered and pressed unfocused ash caption buttons as active.

Show hovered and pressed unfocused ash caption buttons as active.

The caption buttons still work on unfocused captions. To indicate this
the buttons should be drawn in a more active way when hovered or
pressed.

BUG=462119
Committed: https://crrev.com/57101f0da8c66fbe937547cfa00d691a8e00c27b
Cr-Commit-Position: refs/heads/master@{#321031}

[benwells, 2015-03-16 22:44:59]

benwells@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2015-03-17 17:29:29]

lgtm

thanks!

[oshima, 2015-03-17 17:31:39]

forgot to send nit:

https://codereview.chromium.org/994303004/diff/1/ash/frame/caption_buttons/fr...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/994303004/diff/1/ash/frame/caption_buttons/fr...
ash/frame/caption_buttons/frame_caption_button.cc:176: if
(hover_animation_->is_animating() || state() == STATE_HOVERED) {

if (hover_animation_->is_animating())
  inactive_alpha = hover_animation_->CurrentValueBetween(...)
else if (state() == STATE_HOVERED) || state() == STATE_PRESSED)
  inactive_alpha = 1.0f;

?

[benwells, 2015-03-17 23:24:54]

https://codereview.chromium.org/994303004/diff/1/ash/frame/caption_buttons/fr...
File ash/frame/caption_buttons/frame_caption_button.cc (right):

https://codereview.chromium.org/994303004/diff/1/ash/frame/caption_buttons/fr...
ash/frame/caption_buttons/frame_caption_button.cc:176: if
(hover_animation_->is_animating() || state() == STATE_HOVERED) {
On 2015/03/17 17:31:39, oshima wrote:
> 
> if (hover_animation_->is_animating())
>   inactive_alpha = hover_animation_->CurrentValueBetween(...)
> else if (state() == STATE_HOVERED) || state() == STATE_PRESSED)
>   inactive_alpha = 1.0f;
> 
> ?

Done.

[benwells, 2015-03-17 23:25:01]

The CQ bit was checked by benwells@chromium.org

[benwells, 2015-03-17 23:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/994303004/#ps20001 (title:
"Nit")

[commit-bot: I haz the power, 2015-03-17 23:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994303004/20001

[commit-bot: I haz the power, 2015-03-18 00:27:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-18 00:27:56]

Patchset 2 (id:??) landed as
https://crrev.com/57101f0da8c66fbe937547cfa00d691a8e00c27b
Cr-Commit-Position: refs/heads/master@{#321031}