Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 994283006: Add initial test and build files for Robolectric unit test suites. (Closed)

Created:
5 years, 9 months ago by mikecase (-- gone --)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dgn, jam, klundberg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add initial test and build files for Robolectric unit test suites. Robolectric allows us to run tests that use Android code in the host JVM. This means faster and more stable tests since we don't have to deal with a device. This CL has the build file changes to build the unit test suite, and two example tests that have been converted to run with Robolectric. BUG=448030 Committed: https://crrev.com/88322140efede0360bd1e119ef574cdf78edea39 Cr-Commit-Position: refs/heads/master@{#322512}

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Addressed jbudorick's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -118 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java View 1 2 14 chunks +47 lines, -34 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +20 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A + content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java View 1 2 10 chunks +99 lines, -84 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
mikecase (-- gone --)
5 years, 9 months ago (2015-03-23 22:13:14 UTC) #2
mikecase (-- gone --)
5 years, 9 months ago (2015-03-23 22:14:19 UTC) #3
jbudorick
https://codereview.chromium.org/994283006/diff/20001/content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java File content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java (right): https://codereview.chromium.org/994283006/diff/20001/content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java#newcode29 content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java:29: @RunWith(LocalRobolectricTestRunner.class) Converting these before we've got the bots set ...
5 years, 9 months ago (2015-03-23 22:32:25 UTC) #4
mikecase (-- gone --)
https://codereview.chromium.org/994283006/diff/20001/content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java File content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java (right): https://codereview.chromium.org/994283006/diff/20001/content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java#newcode29 content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java:29: @RunWith(LocalRobolectricTestRunner.class) On 2015/03/23 22:32:24, jbudorick wrote: > Converting these ...
5 years, 9 months ago (2015-03-24 21:14:46 UTC) #6
jbudorick
https://codereview.chromium.org/994283006/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java File chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java (right): https://codereview.chromium.org/994283006/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java#newcode7 chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java:7: import static org.junit.Assert.assertEquals; nix the import statics. https://codereview.chromium.org/994283006/diff/20001/content/public/android/junit/src/org/chromium/content/browser/input/GamepadMappingsTest.java File ...
5 years, 9 months ago (2015-03-24 21:27:07 UTC) #7
mikecase (-- gone --)
https://codereview.chromium.org/994283006/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java File chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java (right): https://codereview.chromium.org/994283006/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java#newcode7 chrome/android/junit/src/org/chromium/chrome/browser/omaha/ResponseParserTest.java:7: import static org.junit.Assert.assertEquals; On 2015/03/24 21:27:07, jbudorick wrote: > ...
5 years, 9 months ago (2015-03-24 22:00:40 UTC) #8
mikecase (-- gone --)
+ nyquist for chrome/android/ + tedchoc for content/public/android/ + cjhopman for build files Added build ...
5 years, 9 months ago (2015-03-24 22:11:30 UTC) #10
cjhopman
lgtm
5 years, 9 months ago (2015-03-25 02:28:15 UTC) #11
mikecase (-- gone --)
5 years, 9 months ago (2015-03-26 17:32:13 UTC) #12
Ted C
lgtm
5 years, 9 months ago (2015-03-26 17:52:23 UTC) #13
nyquist
chrome/android lgtm
5 years, 9 months ago (2015-03-26 21:11:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994283006/60001
5 years, 9 months ago (2015-03-26 21:26:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/72445)
5 years, 9 months ago (2015-03-26 21:33:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994283006/60001
5 years, 9 months ago (2015-03-27 00:38:43 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-27 00:46:23 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 00:47:13 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88322140efede0360bd1e119ef574cdf78edea39
Cr-Commit-Position: refs/heads/master@{#322512}

Powered by Google App Engine
This is Rietveld 408576698