Rewrite session cache in OpenSSL ports.

net/socket/ssl_client_socket_openssl.h

Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index 6aaf1e16672d65dc753da56ded07c2e90f546a34..9481a337e8f9b4a63559ea36094060ca0393f8ef 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -296,11 +296,10 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
   std::string channel_id_cert_;
   // True if channel ID extension was negotiated.
   bool channel_id_xtn_negotiated_;
-  // True if InfoCallback has been run with result = SSL_CB_HANDSHAKE_DONE.
+  // True if the initial handshake has completed.
   bool handshake_succeeded_;
-  // True if MarkSSLSessionAsGood has been called for this socket's
-  // SSL session.
-  bool marked_session_as_good_;
+  // True if the initial handshake's certificate has been verified.
+  bool certificate_verified_;

[Ryan Sleevi, 2015/03/17 00:50:33]

First blush review: This strikes me as a bad thing. "marked_session_as_good_"
was meant to also consider the Finished message and not mark a session as good
that has a bad finished message.

(After reviewing .cc): Hrm. I see that was a mistaken assumption on my part. I
suppose this rename is fine.

[davidben, 2015/03/20 22:41:26]

Acknowledged.

   // The request handle for |channel_id_service_|.
   ChannelIDService::RequestHandle channel_id_request_handle_;