Fix an browser crash after video decoder failed to get created

Fix an browser crash after video decoder failed to get created

If we fail to create the java MediaCodec, we should early return in VideoCodecBridge::CreateDecoder(). Otherwise, we will hit NPE.

BUG=329742
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242129

[qinmin, 2013-12-19 02:26:20]

PTAL

[xhwang, 2013-12-19 07:29:05]

https://codereview.chromium.org/99423010/diff/1/media/base/android/media_code...
File media/base/android/media_codec_bridge.cc (right):

https://codereview.chromium.org/99423010/diff/1/media/base/android/media_code...
media/base/android/media_codec_bridge.cc:640: return NULL;
Shall we have a Create function that could return NULL (preferably in Java)?

[qinmin, 2013-12-19 18:26:25]

https://codereview.chromium.org/99423010/diff/1/media/base/android/media_code...
File media/base/android/media_codec_bridge.cc (right):

https://codereview.chromium.org/99423010/diff/1/media/base/android/media_code...
media/base/android/media_codec_bridge.cc:640: return NULL;
The java side MediaCodecBridge.Create() function already returning a NULL.
If we really want to get rid of this if statement, then we have to either 
1. create the java object here rather than in MediaCodecBridge ctor. And then we
need to have another contructor in VideoDecoderBridge which takes a jobject as
an input. Or
2. Have a static MediaCodecBridge::Create() function, and do type cast in all
child classes's Create() function.

I feel both approaches are not elegant.



On 2013/12/19 07:29:05, xhwang wrote:
> Shall we have a Create function that could return NULL (preferably in Java)?

[xhwang, 2013-12-19 23:35:50]

lgtm, thanks for the explanation!

[commit-bot: I haz the power, 2013-12-20 00:24:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/99423010/1

[commit-bot: I haz the power, 2013-12-20 09:02:56]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 16:53:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/99423010/1

[commit-bot: I haz the power, 2013-12-20 18:59:36]

Change committed as 242129