[SafeBrowsing] Reset malware indicator on page nav start.

chrome/browser/safe_browsing/client_side_detection_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/safe_browsing/browser_feature_extractor.h"
 #include "chrome/browser/safe_browsing/database_manager.h"
 #include "chrome/browser/safe_browsing/ui_manager.h"
+#include "content/public/browser/navigation_controller.h"

[Scott Hess - ex-Googler, 2013/12/12 21:28:44]

I can see IWYU arguments for this, but do those apply when the class you're
subclassing should have provided everything necessary to declare your override? 
[I honestly don't know, I could see it going both ways.]

[Greg Billock, 2013/12/12 22:14:44]

I'm flexible. Agreed that the super-type has to include it.

 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/resource_request_details.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "url/gurl.h"
 
 namespace safe_browsing {
 class ClientPhishingRequest;
 class ClientSideDetectionService;
 
 // This class is used to receive the IPC from the renderer which
@@ skipping 13 matching lines @@
   // From content::WebContentsObserver.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // From content::WebContentsObserver.  If we navigate away we cancel all
   // pending callbacks that could show an interstitial, and check to see whether
   // we should classify the new URL.
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
+  // From content::WebContentsObserver. Causes a reset to the
+  // malware_or_phishing_match_ indicator.
+  virtual void DidStartNavigationToPendingEntry(
+      const GURL& url,
+      content::NavigationController::ReloadType reload_type) OVERRIDE;
+
   // Called when the SafeBrowsingService found a hit with one of the
   // SafeBrowsing lists.  This method is called on the UI thread.
   virtual void OnSafeBrowsingHit(
       const SafeBrowsingUIManager::UnsafeResource& resource) OVERRIDE;
 
   // Called when the SafeBrowsingService finds a match on the SB lists.
   // Called on the UI thread. Called even if the resource is whitelisted.
   virtual void OnSafeBrowsingMatch(
       const SafeBrowsingUIManager::UnsafeResource& resource) OVERRIDE;
 
@@ skipping 116 matching lines @@
   // Set to true if we got a match on malware or phishing for the current
   // page load. Is reset to false when DidNavigateMainFrame is received.
   bool malware_or_phishing_match_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionHost);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_