Issue 99423004: Fix for SkPathRef::CreateTransformedCopy bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99423004: Fix for SkPathRef::CreateTransformedCopy bug (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
bsalomon, djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Even when the dest is unique we need to ensure that we have enough space for mapPoints to land its results. When src and dst are the same we have to be careful not to delete the data we want to transform (in resetToSize). This CL includes changes to the path test that would've caught this case.

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -35 lines)			Patch
	M	src/core/SkPathRef.cpp	View		1 chunk	+8 lines, -2 lines	0 comments	Download
	M	tests/PathTest.cpp	View		3 chunks	+76 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages