nss: fix order of parenthesis.

net/third_party/nss/ssl/ssl3con.c

 /* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * SSL3 Protocol
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* TODO(ekr): Implement HelloVerifyRequest on server side. OK for now. */
 
@@ skipping 10694 matching lines @@
     rv = ssl3_AppendHandshakeNumber(ss, ssl_channel_id_xtn, 2);
     if (rv != SECSuccess)
         goto loser;     /* error code set by AppendHandshake */
     rv = ssl3_AppendHandshakeNumber(ss, CHANNEL_ID_LENGTH, 2);
     if (rv != SECSuccess)
         goto loser;     /* error code set by AppendHandshake */
 
     spki = SECKEY_EncodeDERSubjectPublicKeyInfo(ss->ssl3.channelIDPub);
 
     if (spki->len != sizeof(P256_SPKI_PREFIX) + CHANNEL_ID_PUBLIC_KEY_LENGTH ||
-        memcmp(spki->data, P256_SPKI_PREFIX, sizeof(P256_SPKI_PREFIX) != 0)) {

[wtc, 2013/12/03 01:27:33]

So we were comparing only one byte :-(

+        memcmp(spki->data, P256_SPKI_PREFIX, sizeof(P256_SPKI_PREFIX)) != 0) {
         PORT_SetError(SSL_ERROR_INVALID_CHANNEL_ID_KEY);
         rv = SECFailure;
         goto loser;
     }
 
     pub_bytes = spki->data + sizeof(P256_SPKI_PREFIX);
 
     signed_data_len = 0;
     memcpy(signed_data + signed_data_len, CHANNEL_ID_MAGIC,
            sizeof(CHANNEL_ID_MAGIC));
@@ skipping 1922 matching lines @@
             PORT_Free(ss->ssl3.hs.recvdFragments.buf);
         }
     }
 
     ss->ssl3.initialized = PR_FALSE;
 
     SECITEM_FreeItem(&ss->ssl3.nextProto, PR_FALSE);
 }
 
 /* End of ssl3con.c */