Make android-chrome bisect work with archives.

tools/auto_bisect/bisect_perf_regression_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import shutil
 import sys
 import unittest
 
@@ skipping 463 matching lines @@
 
   @mock.patch('bisect_utils.RunGit')
   def testSyncToRevisionForWebKit(self, mock_RunGit):
     bisect_instance = _GetBisectPerformanceMetricsInstance(DEFAULT_OPTIONS)
     mock_RunGit.return_value = None, None
     bisect_instance._SyncRevision(
         'webkit', 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61' , None)
     expected_params = ['checkout', 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61']
     mock_RunGit.assert_called_with(expected_params)
 
+  def test_TryJobSvnRepo_Perf(self):
+    self.assertEqual(bisect_perf_regression.PERF_SVN_REPO_URL,
+        bisect_perf_regression._TryJobSvnRepo(fetch_build.PERF_BUILDER))
+
+  def test_TryJobSvnRepo_Full(self):
+    self.assertEqual(bisect_perf_regression.FULL_SVN_REPO_URL,
+        bisect_perf_regression._TryJobSvnRepo(fetch_build.FULL_BUILDER))

[qyearsley, 2015/03/10 23:52:32]

Optional:

def testTryJobSvnRepoWithUnknownBuilderTypeThrowsError(self):
  with self.assertRaises(NotImplementedError):
    bisect_perf_regression._TryJobSvnRepo('foo')

[prasadv, 2015/03/11 18:50:39]

Done.

+
+  def test_IsDownloadable_Chromium(self):
+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'builder_type': 'perf'})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertTrue(bisect_instance.IsDownloadable('chromium'))
+
+  def test_IsDownloadable_No_BuilderType(self):

[qyearsley, 2015/03/10 23:52:32]

Although I like underscores in test method names, and readability is the most
important thing for test method names, to be consistent with the other test
method names here I would not use underscores.

I changed all the test method names in the perf dashboard tests to have the
format test<Thing>_<Condition>_<Behavior> based on this doc:
http://go/unit-test-practices#naming. If you want to use this convention, then
this method name would be testIsDownloadable_NoBuilderType_ReturnsFalse

[prasadv, 2015/03/11 18:50:39]

Done.

+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'builder_type': ''})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertFalse(bisect_instance.IsDownloadable('chromium'))
+
+  def test_IsDownloadable_DEPS(self):
+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'builder_type': 'perf'})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertTrue(bisect_instance.IsDownloadable('v8'))
+
+  def test_IsDownloadable_android_chrome(self):
+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'target_platform': 'android-chrome', 'builder_type': 'perf'})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertTrue(bisect_instance.IsDownloadable('android-chrome'))
+
+  def test_IsDownloadable_android_chrome_DEPS_Chromium(self):
+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'target_platform': 'android-chrome', 'builder_type': 'perf'})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertFalse(bisect_instance.IsDownloadable('Chromium'))
+
+  def test_IsDownloadable_android_chrome_DEPS_V8(self):
+    opts = dict(DEFAULT_OPTIONS)
+    opts.update({'target_platform': 'android-chrome', 'builder_type': 'perf'})
+    bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
+    self.assertFalse(bisect_instance.IsDownloadable('v8'))

[qyearsley, 2015/03/10 23:52:32]

I like the fact that these test methods are quite simple and only test one thing
each.

If you want to factor out some of the repetition, you could also do:

def _CheckIsDownloadable(depot, target_platform='chromium',
builder_type='perf'):
  opts = dict(DEFAULT_OPTIONS)
  opts.update({'target_platform': target_platform, 'builder_type':
builder_type})
  bisect_instance = _GetBisectPerformanceMetricsInstance(opts)
  return bisect_instance.IsDownloadable(depot)

and then the other ones could be a bit shorter, e.g.:

def test_IsDownloadable_android_chrome_DEPS_V8(self):
  self.assertFalse(self._CheckIsDownloadable('v8', 'android-chrome', 'perf')

[prasadv, 2015/03/11 18:50:38]

Done.

+
 
 class DepotDirectoryRegistryTest(unittest.TestCase):
 
   def setUp(self):
     self.old_chdir = os.chdir
     os.chdir = self.mockChdir
     self.old_depot_names = bisect_utils.DEPOT_NAMES
     bisect_utils.DEPOT_NAMES = ['mock_depot']
     self.old_depot_deps_name = bisect_utils.DEPOT_DEPS_NAME
     bisect_utils.DEPOT_DEPS_NAME = {'mock_depot': {'src': 'src/foo'}}
@@ skipping 170 matching lines @@
          ], (None, 0)),
     ]
     self._SetupRunGitMock(try_cmd)
     bisect_perf_regression._StartBuilderTryJob(
         fetch_build.PERF_BUILDER, git_revision, bot_name, bisect_job_name,
         patch)
 
 
 if __name__ == '__main__':
   unittest.main()