Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 994153003: Rerun convert_dict on en-US and en-CA (Closed)

Created:
5 years, 9 months ago by please use gerrit instead
Modified:
5 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git@master
Target Ref:
refs/remotes/origin/master
Visibility:
Public.

Description

Rerun convert_dict on en-US and en-CA Dictionaries en-US-6-0.bdic and en-CA-6-0.bdic are missing REP rules. For example, "a lot" would not be suggested for "alot". This patch adds en-US-6-1.bdic and en-US-6-1.bdic, which have the REP rules after rerunning convert_dict. The Chrome side of rolling the dictionaries will include a test for "alot" -> "a lot" suggestion. BUG=165079 R=groby@chromium.org TBR=darin@chromium.org Committed: 377b158a8996e3a31961f14c2b7699cff91d615d Committed: 294404

Patch Set 1 #

Patch Set 2 : Post git svn init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
A + en-CA-6-1.bdic View Binary file 0 comments Download
A + en-US-6-1.bdic View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
please use gerrit instead
Rachel, PTAL. It appears that I used an old version of convert_dict that stripped REP ...
5 years, 9 months ago (2015-03-10 22:10:29 UTC) #2
groby-ooo-7-16
lgtm
5 years, 9 months ago (2015-03-10 23:34:30 UTC) #3
please use gerrit instead
Committed patchset #1 (id:1) manually as 377b158a8996e3a31961f14c2b7699cff91d615d (presubmit successful).
5 years, 9 months ago (2015-03-11 16:00:52 UTC) #4
please use gerrit instead
5 years, 9 months ago (2015-03-11 16:17:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 294404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698