Issue 994143002: Add initialDelay to AnimationGenerator and add Animation class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 994143002: Add initialDelay to AnimationGenerator and add Animation class (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add initialDelay to AnimationGenerator and add Animation class. This patch allows for an initial delay before an animation begins and also adds an Animation class which encapsulates a value which is long-lived, can be explicitly set and also animated from its current value to another value. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/34ecbcfb46fafe71dc21b152224f9e3acb5213b8

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Total comments: 1

Patch Set 4 : cr comments #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -43 lines)			Patch
	M	sky/examples/fn/widgets/drawer.dart	View		3 chunks	+13 lines, -41 lines	0 comments	Download
	M	sky/framework/animation/generator.dart	View	1 2 3	4 chunks	+52 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/994143002/diff/40001/sky/framework/animation/generator.dart File sky/framework/animation/generator.dart (right): https://codereview.chromium.org/994143002/diff/40001/sky/framework/animation/generator.dart#newcode80 sky/framework/animation/generator.dart:80: .takeWhile(_checkForCompletion) // takeUntil takeUntil?

5 years, 9 months ago (2015-03-10 19:20:16 UTC) #3

rafaelw

5 years, 9 months ago (2015-03-10 19:22:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
34ecbcfb46fafe71dc21b152224f9e3acb5213b8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages