Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 994133002: Generate globally (cross-process) unique IDs for memory tracing dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/trace_event_impl.h ('K') | « base/trace_event/trace_event_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_impl.cc
diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc
index 72b46f92914c8d73d51068324f6c2a757371b5d1..842b608d9ca2d613fad9d4c0019ee02c41e7e5c8 100644
--- a/base/trace_event/trace_event_impl.cc
+++ b/base/trace_event/trace_event_impl.cc
@@ -1908,7 +1908,7 @@ TraceEventHandle TraceLog::AddTraceEventWithThreadIdAndTimestamp(
DCHECK(!timestamp.is_null());
if (flags & TRACE_EVENT_FLAG_MANGLE_ID)
- id ^= process_id_hash_;
+ id = HashEventId(id);
TimeTicks offset_event_timestamp = OffsetTimestamp(timestamp);
TimeTicks now = flags & TRACE_EVENT_FLAG_EXPLICIT_TIMESTAMP ?
@@ -2177,6 +2177,11 @@ void TraceLog::CancelWatchEvent() {
watch_event_callback_.Reset();
}
+uint64 TraceLog::HashEventId(uint64 id) {
+ return id ^ process_id_hash_;
+}
+
+
void TraceLog::AddMetadataEventsWhileLocked() {
lock_.AssertAcquired();
« base/trace_event/trace_event_impl.h ('K') | « base/trace_event/trace_event_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698