Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3477)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 994133002: Generate globally (cross-process) unique IDs for memory tracing dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/trace_event_impl.h » ('j') | base/trace_event/trace_event_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index 8b2d930a4bc5ab1e09b0f4295910eff07d474a53..10a842ca19245dbedd9dde77572c1c4ae622afb4 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -106,9 +106,8 @@ void MemoryDumpManager::RequestDumpPoint(DumpPointType dump_point_type) {
if (!UNLIKELY(subtle::NoBarrier_Load(&memory_tracing_enabled_)))
return;
- // TODO(primiano): Make guid actually unique (cross-process) by hashing it
- // with the PID. See crbug.com/462931 for details.
- const uint64 guid = g_next_guid.GetNext();
+ const uint64 guid = base::trace_event::TraceLog::GetInstance()->HashEventId(
Primiano Tucci (use gerrit) 2015/04/13 22:13:58 nit: no need for base::trace_event as you are alre
+ g_next_guid.GetNext());
CreateLocalDumpPoint(dump_point_type, guid);
}
« no previous file with comments | « no previous file | base/trace_event/trace_event_impl.h » ('j') | base/trace_event/trace_event_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698