runtime/vm/class_finalizer.cc - Issue 994103002: Make sure the mixin class is finalized immediately (and not some time later)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/class_finalizer.cc

Issue 994103002: Make sure the mixin class is finalized immediately (and not some time later) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/class_finalizer.cc

===================================================================

--- runtime/vm/class_finalizer.cc (revision 44381)

+++ runtime/vm/class_finalizer.cc (working copy)

@@ -2098,8 +2098,7 @@

ASSERT(!mixin_type.IsNull());

ASSERT(mixin_type.HasResolvedTypeClass());

const Class& mixin_cls = Class::Handle(isolate, mixin_type.type_class());

- const Error& error = Error::Handle(mixin_cls.EnsureIsFinalized(isolate));

- ASSERT(error.IsNull());

+ FinalizeClass(mixin_cls);

// If the mixin is a mixin application alias class, there are no members to

// apply here. A new synthesized class representing the aliased mixin

// application class was inserted in the super chain of this mixin application

« no previous file with comments | « no previous file | tests/language/regress_22719_test.dart » ('j') | no next file with comments »