Issue 994063003: Move TextTrackContainer::updateSizes to the layout-side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 994063003: Move TextTrackContainer::updateSizes to the layout-side (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, nessy, zoltan1, eae+blinkwatch, philipj_slow, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, Dominik Röttsches, blink-reviews-html_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move TextTrackContainer::updateSizes to the layout-side This method is only called from the corresponding LayoutObject (LayoutTextTrackContainer), so move it and its state there instead. When the text track container has been properly separated from the media controls it should be possible to simplify this further by doing this in the media element's layout object. BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191653

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -38 lines)			Patch
M	Source/core/html/track/TextTrackContainer.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/html/track/TextTrackContainer.cpp	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	Source/core/layout/LayoutTextTrackContainer.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/layout/LayoutTextTrackContainer.cpp	View	2 chunks	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994063003/1

5 years, 9 months ago (2015-03-10 17:24:29 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 19:32:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191653

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages