Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: src/hydrogen-instructions.h

Issue 994043003: [strong] More scoping related errors: object literal methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: moar code reviews Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/globals.h ('k') | src/objects.h » ('j') | src/preparser.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 7562 matching lines...) Expand 10 before | Expand all | Expand 10 after
7573 PretenureField::encode(pretenure) | 7573 PretenureField::encode(pretenure) |
7574 HasNoLiteralsField::encode(shared->num_literals() == 0) | 7574 HasNoLiteralsField::encode(shared->num_literals() == 0) |
7575 LanguageModeField::encode(shared->language_mode())) { 7575 LanguageModeField::encode(shared->language_mode())) {
7576 SetOperandAt(0, context); 7576 SetOperandAt(0, context);
7577 set_representation(Representation::Tagged()); 7577 set_representation(Representation::Tagged());
7578 SetChangesFlag(kNewSpacePromotion); 7578 SetChangesFlag(kNewSpacePromotion);
7579 } 7579 }
7580 7580
7581 bool IsDeletable() const OVERRIDE { return true; } 7581 bool IsDeletable() const OVERRIDE { return true; }
7582 7582
7583 class FunctionKindField : public BitField<FunctionKind, 0, 6> {}; 7583 class FunctionKindField : public BitField<FunctionKind, 0, 8> {};
7584 class PretenureField : public BitField<bool, 6, 1> {}; 7584 class PretenureField : public BitField<bool, 8, 1> {};
arv (Not doing code reviews) 2015/03/10 16:49:06 Maybe use kNext here?
7585 class HasNoLiteralsField : public BitField<bool, 7, 1> {}; 7585 class HasNoLiteralsField : public BitField<bool, 9, 1> {};
7586 STATIC_ASSERT(LANGUAGE_END == 3); 7586 STATIC_ASSERT(LANGUAGE_END == 3);
7587 class LanguageModeField : public BitField<LanguageMode, 8, 2> {}; 7587 class LanguageModeField : public BitField<LanguageMode, 10, 2> {};
7588 7588
7589 Handle<SharedFunctionInfo> shared_info_; 7589 Handle<SharedFunctionInfo> shared_info_;
7590 uint32_t bit_field_; 7590 uint32_t bit_field_;
7591 }; 7591 };
7592 7592
7593 7593
7594 class HTypeof FINAL : public HTemplateInstruction<2> { 7594 class HTypeof FINAL : public HTemplateInstruction<2> {
7595 public: 7595 public:
7596 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P1(HTypeof, HValue*); 7596 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P1(HTypeof, HValue*);
7597 7597
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
7964 }; 7964 };
7965 7965
7966 7966
7967 7967
7968 #undef DECLARE_INSTRUCTION 7968 #undef DECLARE_INSTRUCTION
7969 #undef DECLARE_CONCRETE_INSTRUCTION 7969 #undef DECLARE_CONCRETE_INSTRUCTION
7970 7970
7971 } } // namespace v8::internal 7971 } } // namespace v8::internal
7972 7972
7973 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7973 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/globals.h ('k') | src/objects.h » ('j') | src/preparser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698