Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 993963002: Converted Crankshaft to have its own list of known intrinsics. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Converted Crankshaft to have its own list of known intrinsics. We can remove a few of them now (those which unconditionally bailout), but this will be done in a separate CL to see any impact separately. BUG=v8:3947 LOG=n Committed: https://crrev.com/507c11a02631c3934cd76eb34f8530ad7f86099b Cr-Commit-Position: refs/heads/master@{#27102}

Patch Set 1 #

Patch Set 2 : Fixed undef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -62 lines) Patch
M src/hydrogen.h View 1 2 chunks +80 lines, -15 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +15 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-10 12:48:27 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-10 12:54:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993963002/20001
5 years, 9 months ago (2015-03-10 12:57:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 13:18:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 13:18:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/507c11a02631c3934cd76eb34f8530ad7f86099b
Cr-Commit-Position: refs/heads/master@{#27102}

Powered by Google App Engine
This is Rietveld 408576698