[cr tool] Adding the install command

[cr tool] Adding the install command

BUG=316397
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238386

[Andrew Hayden (chromium.org), 2013-12-02 16:44:25]

lgtm

"I take the binaries produced by the builder and install them with the
installer"

[bulach, 2013-12-02 18:33:09]

lgtm w/ one suggestion:

https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install.py
File tools/cr/cr/commands/install.py (right):

https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install....
tools/cr/cr/commands/install.py:15: You can set the builder to a skip version to
bypass that stage.
this comment is a bit cryptic.. :) is it a command line flag? or a config? it
may be clearer as something like:
"Use --skip to bypass the build check stage"
or
"Do xyx to bypass the build check stage"

[ian_cottrell, 2013-12-02 18:44:01]

On 2013/12/02 18:33:09, bulach wrote:
> lgtm w/ one suggestion:
> 
>
https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install.py
> File tools/cr/cr/commands/install.py (right):
> 
>
https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install....
> tools/cr/cr/commands/install.py:15: You can set the builder to a skip version
to
> bypass that stage.
> this comment is a bit cryptic.. :) is it a command line flag? or a config? it
> may be clearer as something like:
> "Use --skip to bypass the build check stage"
> or
> "Do xyx to bypass the build check stage"

The trouble is that this class does not know what you need to do, it just gets
the active builder with no idea how it was selected.
I did originally put the message you suggest in here (--builder=skip is how) but
then took it out because I decided it does not belong here, but I do think it's
important point out that skip builders exist here, they are easy to find and use
when you know they exist.

[ian_cottrell, 2013-12-02 22:45:59]

On 2013/12/02 18:44:01, ian_cottrell wrote:
> On 2013/12/02 18:33:09, bulach wrote:
> > lgtm w/ one suggestion:
> > 
> >
>
https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install.py
> > File tools/cr/cr/commands/install.py (right):
> > 
> >
>
https://codereview.chromium.org/99393002/diff/1/tools/cr/cr/commands/install....
> > tools/cr/cr/commands/install.py:15: You can set the builder to a skip
version
> to
> > bypass that stage.
> > this comment is a bit cryptic.. :) is it a command line flag? or a config?
it
> > may be clearer as something like:
> > "Use --skip to bypass the build check stage"
> > or
> > "Do xyx to bypass the build check stage"
> 
> The trouble is that this class does not know what you need to do, it just gets
> the active builder with no idea how it was selected.
> I did originally put the message you suggest in here (--builder=skip is how)
but
> then took it out because I decided it does not belong here, but I do think
it's
> important point out that skip builders exist here, they are easy to find and
use
> when you know they exist.

Changed the comment, is this better?

[bulach, 2013-12-03 10:58:14]

lgtm, thanks!

https://codereview.chromium.org/99393002/diff/40001/tools/cr/cr/commands/inst...
File tools/cr/cr/commands/install.py (right):

https://codereview.chromium.org/99393002/diff/40001/tools/cr/cr/commands/inst...
tools/cr/cr/commands/install.py:15: The builder installs it's command line
arguments, and you can use those to
nit: s/it's/its/

[ian_cottrell, 2013-12-03 11:37:17]

https://codereview.chromium.org/99393002/diff/40001/tools/cr/cr/commands/inst...
File tools/cr/cr/commands/install.py (right):

https://codereview.chromium.org/99393002/diff/40001/tools/cr/cr/commands/inst...
tools/cr/cr/commands/install.py:15: The builder installs it's command line
arguments, and you can use those to
On 2013/12/03 10:58:15, bulach wrote:
> nit: s/it's/its/

Done.

[commit-bot: I haz the power, 2013-12-03 11:37:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/99393002/60001

[commit-bot: I haz the power, 2013-12-03 13:47:46]

Change committed as 238386