skia/ext/benchmarking_canvas.h - Issue 993893004: Add back overdraw visualization for Skia BenchmarkingCanvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/benchmarking_canvas.h

Issue 993893004: Add back overdraw visualization for Skia BenchmarkingCanvas (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove todo Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/ext/benchmarking_canvas.h

diff --git a/skia/ext/benchmarking_canvas.h b/skia/ext/benchmarking_canvas.h

index 4f2e25718e5060822ed8ea12a8cbf83952f853f5..18a26ca7823d65bdf18f7958a03c4d46b8ef0bb6 100644

--- a/skia/ext/benchmarking_canvas.h

+++ b/skia/ext/benchmarking_canvas.h

@@ -16,8 +16,6 @@ public:

~BenchmarkingCanvas() override;

enum Flags {

- // TODO(fmalita): add overdraw visualization support

- // (http://crbug.com/461534)

kOverdrawVisualization_Flag = 0x01,

};

« no previous file with comments | « no previous file | skia/ext/benchmarking_canvas.cc » ('j') | skia/ext/benchmarking_canvas.cc » ('J')