Add the data attribute to the Notification object

LayoutTests/http/tests/notifications/notification-properties.html

Index: LayoutTests/http/tests/notifications/notification-properties.html
diff --git a/LayoutTests/http/tests/notifications/notification-properties.html b/LayoutTests/http/tests/notifications/notification-properties.html
index a2d4e0bb6bcb28174a851c2acd10cc9e5b7d2f99..50e2ab5f13bd16c51b3d0af10bbb6fdd2180b58a 100644
--- a/LayoutTests/http/tests/notifications/notification-properties.html
+++ b/LayoutTests/http/tests/notifications/notification-properties.html
@@ -19,7 +19,8 @@
                 lang: "nl-NL",
                 body: "Hallo, wereld!",
                 tag: "notification",
-                icon: "http://localhost/my_icon.png"
+                icon: "http://localhost/my_icon.png",
+                data: "my data"
             };
 
             var notification = new Notification("My Notification", options);
@@ -30,6 +31,7 @@
             assert_equals(notification.body, options.body);
             assert_equals(notification.tag, options.tag);
             assert_equals(notification.icon, options.icon);
+            assert_equals(notification.data, options.data);
 
             var emptyNotification = new Notification("My Notification");
 
@@ -39,6 +41,7 @@
             assert_equals(emptyNotification.body, "");
             assert_equals(emptyNotification.tag, "");
             assert_equals(emptyNotification.icon, "");
+            assert_equals(emptyNotification.data, null);
 
             var invalidIconNotification = new Notification("My Notification", {
                 icon: "http://test:test/"
@@ -60,6 +63,17 @@
             // Setting an empty string as the tag should be equal to not setting the tag at all.
             assert_equals(noTagNotification.tag, emptyTagNotification.tag);
 
+            // Set notification's data to a structured clone of options's data.

[Peter Beverloo, 2015/03/10 23:34:26]

While I think that the three earlier additions to this file are great, I think
testing the abilities of the .data property should be done in a separate test,
also testing a few more cases.

Some things you can think about:

(1) Storing and restoring different types of values (number, string, object,
array, Number.NaN, and so on).

Since we don't have to test all of SerializedScriptValue, having some kind of
helper function for doing this concisely would be great, having each check look
like:

function assertNotificationDataReflects(value) {
  var notification = new Notification('Title', { data: value });
  assert_equals(notification.data, notification);
}

assertNotificationDataReflects(true);
assertNotificationDataReflects({ a: 1, b: 2 });

(2) Verifying the exception throwing behavior of the method.

It requires adding [RaisesException] to the IDL, so it can throw exceptions. We
need to make sure that these are properly shown when this is the case. One
example case in which this can occur (I think) is when you have a function in
the data property:

new Notification('Title', {
  data: function() { return 5; }
});

[Sanghyun Park, 2015/03/11 10:59:51]

Okay I'll make new test file about data property.
It's good idea.
I'll add these. :)
I'll also add negative tests like your comment. :)

+            var serializedDataNotification = new Notification("My Notification", {
+                data: {
+                    first: "first",
+                    second: "second"
+                }
+            });
+
+            assert_equals(serializedDataNotification.data.first, "first");
+            assert_equals(serializedDataNotification.data.second, "second");
+
       }, 'Checks the properties exposed on the Notification object.');
     </script>
   </body>