Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/notifications/WebNotificationData.h
diff --git a/public/platform/modules/notifications/WebNotificationData.h b/public/platform/modules/notifications/WebNotificationData.h
index 537ed26aa7edaf5b6c892db2cc01cd45f72cf586..e979d385c1fce807089a9853ef6dfb6498e46b11 100644
--- a/public/platform/modules/notifications/WebNotificationData.h
+++ b/public/platform/modules/notifications/WebNotificationData.h
@@ -7,6 +7,7 @@
#include "public/platform/WebString.h"
#include "public/platform/WebURL.h"
+#include "public/web/WebSerializedScriptValue.h"
Peter Beverloo 2015/03/12 20:30:46 public/platform/ (where this files live in) cannot
Sanghyun Park 2015/03/13 02:57:07 I refer the this document about this. [1] http://w
Sanghyun Park 2015/03/13 07:58:08 Oops. I'm misunderstanding, At first, I'll split t
namespace blink {
@@ -35,7 +36,7 @@ struct WebNotificationData {
{
}
- WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent)
+ WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent, const WebSerializedScriptValue& data)
: title(title)
, direction(direction)
, lang(lang)
@@ -43,6 +44,7 @@ struct WebNotificationData {
, tag(tag)
, icon(icon)
, silent(silent)
+ , data(data)
{
}
@@ -53,6 +55,7 @@ struct WebNotificationData {
WebString tag;
WebURL icon;
bool silent;
+ WebSerializedScriptValue data;
};
} // namespace blink
« Source/modules/notifications/Notification.cpp ('K') | « Source/platform/RuntimeEnabledFeatures.in ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698