Add the data attribute to the Notification object

Source/modules/notifications/Notification.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef Notification_h
 #define Notification_h
 
+#include "bindings/core/v8/SerializedScriptValue.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "modules/EventTargetModules.h"
 #include "platform/AsyncMethodRunner.h"
 #include "platform/heap/Handle.h"
 #include "platform/text/TextDirection.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/modules/notifications/WebNotificationDelegate.h"
 #include "public/platform/modules/notifications/WebNotificationPermission.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/RefCounted.h"
@@ skipping 25 matching lines @@
     DEFINE_ATTRIBUTE_EVENT_LISTENER(show);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(close);
 
     // WebNotificationDelegate implementation.
     void dispatchShowEvent() override;
     void dispatchClickEvent() override;
     void dispatchErrorEvent() override;
     void dispatchCloseEvent() override;
 
+    SerializedScriptValue* data() const { return m_data.get(); }
     String title() const { return m_title; }
     String dir() const { return m_dir; }
     String lang() const { return m_lang; }
     String body() const { return m_body; }
     String tag() const { return m_tag; }
     String icon() const { return m_iconUrl; }
     bool silent() const { return m_silent; }
 
     TextDirection direction() const;
     KURL iconURL() const { return m_iconUrl; }
@@ skipping 19 matching lines @@
 
     void scheduleShow();
 
     // Calling show() may start asynchronous operation. If this object has
     // a V8 wrapper, hasPendingActivity() prevents the wrapper from being
     // collected while m_state is Showing, and so this instance stays alive
     // until the operation completes. Otherwise, you need to hold a ref on this
     // instance until the operation completes.
     void show();
 
+    void setData(PassRefPtr<SerializedScriptValue> data) { m_data = data; }

[Peter Beverloo, 2015/03/12 01:16:26]

nit: please place this under setSilent(). Generally, I try to follow the order
of the IDL file. Same with the getter and the member variable.

[Sanghyun Park, 2015/03/12 02:58:47]

I see. I'll move this under setSlient().

     void setDir(const String& dir) { m_dir = dir; }
     void setLang(const String& lang) { m_lang = lang; }
     void setBody(const String& body) { m_body = body; }
     void setIconUrl(KURL iconUrl) { m_iconUrl = iconUrl; }
     void setTag(const String& tag) { m_tag = tag; }
     void setSilent(bool silent) { m_silent = silent; }
 
     void setPersistentId(const String& persistentId) { m_persistentId = persistentId; }
 
 private:
+    RefPtr<SerializedScriptValue> m_data;
     String m_title;
     String m_dir;
     String m_lang;
     String m_body;
     String m_tag;
     bool m_silent;
 
     KURL m_iconUrl;
 
     // Notifications can either be bound to the page, which means they're identified by
@@ skipping 13 matching lines @@
     void setState(NotificationState state) { m_state = state; }
 
     NotificationState m_state;
 
     AsyncMethodRunner<Notification> m_asyncRunner;
 };
 
 } // namespace blink
 
 #endif // Notification_h