LayoutTests/http/tests/notifications/notification-data-property.html - Issue 993893002: Add the data attribute to the Notification object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/notifications/notification-data-property.html

Issue 993893002: Add the data attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Notifications: The Notification object exposes the expected data prop erty.</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <script>

	10 // Tests that the Notification object exposes the data property per the

	11 // semantics defined by the specification. When the test is being ran

	12 // manually, grant Notification permission first.

	13 if (window.testRunner)

	14 testRunner.clearWebNotificationPermissions();

	15

	16 function assertNotificationDataReflects(value) {

	17 var notification = new Notification('Title', { data: value });

	18

	19 if (value.constructor.toString().indexOf("Object") > -1)
	Peter Beverloo 2015/03/12 01:16:26 You can use some slightly nicer checks here; if ( You can use some slightly nicer checks here; if (Array.isArray(value)) // array else if (typeof value == 'object') // object else // anything else Sanghyun Park 2015/03/12 02:58:47 This is better. I'll fix this. Show quoted text On 2015/03/12 01:16:26, Peter Beverloo wrote: > You can use some slightly nicer checks here; > > if (Array.isArray(value)) > // array > else if (typeof value == 'object') > // object > else > // anything else This is better. I'll fix this.
	20 assert_object_equals(notification.data, value);

	21 else if (value.constructor.toString().indexOf("Array") > -1)

	22 assert_array_equals(notification.data, value);

	23 else

	24 assert_equals(notification.data, value);

	25 }

	26

	27 test(function () {

	28 // Set notification's data of several type to a structured clone of opti ons's data.

	29 assertNotificationDataReflects(true); // Check Boolean type

	30 assertNotificationDataReflects(1024); // Check Number type

	31 assertNotificationDataReflects(Number.NaN); // Check Number.NaN type

	32 assertNotificationDataReflects("any data"); // Check String type

	33

	34 var cars = new Array("Saab", "Volvo", "BMW");

	35 assertNotificationDataReflects(cars); // Check Array type

	36

	37 var obj = { first: "first", second: "second"};

	38 assertNotificationDataReflects(obj); // Check Object

	39

	40 // Verifying the exception throwing behavior of the method.

	41 assert_throws("DataCloneError", function() {

	42 var notification = new Notification('Title', { data: function() { ret urn 1; } });
	Peter Beverloo 2015/03/12 01:16:26 micro nit: indent +1 space micro nit: indent +1 space Sanghyun Park 2015/03/12 02:58:47 Done. Show quoted text On 2015/03/12 01:16:26, Peter Beverloo wrote: > micro nit: indent +1 space Done.
	43 }, "Set function in data");

	44

	45 }, 'Checks the data of several type property exposed on the Notification object.');
	Peter Beverloo 2015/03/12 01:16:26 micro nit: indent -4 spaces micro nit: indent -4 spaces Sanghyun Park 2015/03/12 02:58:47 Done. Show quoted text On 2015/03/12 01:16:26, Peter Beverloo wrote: > micro nit: indent -4 spaces Done.
	46 </script>

	47 </body>

	48 </html>

OLD	NEW