Issue 993883002: convert Function and Promise to maybe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 993883002: convert Function and Promise to maybe (Closed)

Created:
5 years, 9 months ago by dcarney

Modified:
5 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

convert Function and Promise to maybe BUG= Committed: https://crrev.com/66969fb2ad6161d2d1da87cdd6fb50e1e6c970e5 Cr-Commit-Position: refs/heads/master@{#27087}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -137 lines)			Patch
	M	include/v8.h	View	1	6 chunks	+42 lines, -13 lines	0 comments	Download
	M	src/api.cc	View	1	6 chunks	+127 lines, -124 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993883002/20001

5 years, 9 months ago (2015-03-10 08:57:20 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 09:16:09 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/66969fb2ad6161d2d1da87cdd6fb50e1e6c970e5
Cr-Commit-Position: refs/heads/master@{#27087}