chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc - Issue 99383004: [SyncFS] Refine network error handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc

Issue 99383004: [SyncFS] Refine network error handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: buildfix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/list_changes_task.cc ('k') | chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc b/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc

index 04949d3ebc273527b8c0f8abddac3c936be9420a..5c731dc1c3fc69b721c662f53e665c5294455738 100644

--- a/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc

+++ b/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc

@@ -303,11 +303,12 @@ void LocalToRemoteSyncer::DeleteRemoteFile(

void LocalToRemoteSyncer::DidDeleteRemoteFile(

const SyncStatusCallback& callback,

google_apis::GDataErrorCode error) {

- if (error != google_apis::HTTP_SUCCESS &&

+ SyncStatusCode status = GDataErrorCodeToSyncStatusCode(error);

+ if (status != SYNC_STATUS_OK &&

error != google_apis::HTTP_NOT_FOUND &&

error != google_apis::HTTP_PRECONDITION &&

error != google_apis::HTTP_CONFLICT) {

- callback.Run(GDataErrorCodeToSyncStatusCode(error));

+ callback.Run(status);

return;

}