Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 993813002: Refactor metrics callback functions (Closed)

Created:
5 years, 9 months ago by Steven Holte
Modified:
5 years, 9 months ago
Reviewers:
jwd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@states
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor metrics callback functions BUG=410493 Committed: https://crrev.com/a6a391711099ce57b7e8918cc5a0526a2f4b8d46 Cr-Commit-Position: refs/heads/master@{#322221}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -46 lines) Patch
M components/metrics/metrics_service.h View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M components/metrics/metrics_service.cc View 1 2 3 4 chunks +24 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Steven Holte
5 years, 9 months ago (2015-03-21 19:44:36 UTC) #2
jwd
lgtm
5 years, 9 months ago (2015-03-25 18:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993813002/60001
5 years, 9 months ago (2015-03-25 19:06:56 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-25 19:57:29 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:58:10 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a6a391711099ce57b7e8918cc5a0526a2f4b8d46
Cr-Commit-Position: refs/heads/master@{#322221}

Powered by Google App Engine
This is Rietveld 408576698