gm/gm_json.py - Issue 99373010: rebaseline_server: allow spaces within test/config names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/gm_json.py

Issue 99373010: rebaseline_server: allow spaces within test/config names (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/gm_json.py

diff --git a/gm/gm_json.py b/gm/gm_json.py

index 2c37d6a35c51c40329e2a56b249661da62b10442..7cd4455f797371acf14c9fe05f576935f4b137da 100644

--- a/gm/gm_json.py

+++ b/gm/gm_json.py

@@ -91,7 +91,7 @@ SKIMAGE_ACTUALS_BASE_URL = (

SKIMAGE_EXPECTATIONS_ROOT = os.path.join('expectations', 'skimage')

# Pattern used to assemble each image's filename

-IMAGE_FILENAME_PATTERN = '(\S+)_(\S+)\.png' # matches (testname, config)

+IMAGE_FILENAME_PATTERN = '(.+)_(.+)\.png' # matches (testname, config)

def CreateGmActualUrl(test_name, hash_type, hash_digest,

gm_actuals_root_url=GM_ACTUALS_ROOT_HTTP_URL):

« no previous file with comments | « no previous file | no next file » | no next file with comments »