Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993713002: Fix template angle bracket syntax in CSS subdirs (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, blink-reviews-style_chromium.org, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, dstockwell, dglazkov+blink, Steve Block, apavlov+blink_chromium.org, darktears, Eric Willigers, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in CSS subdirs In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -83 lines) Patch
M Source/core/css/invalidation/DescendantInvalidationSet.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/invalidation/StyleSheetInvalidationAnalysis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 8 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 9 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/parser/BisonCSSParserTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSTokenizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSGrammar.y View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-09 21:30:40 UTC) #2
Timothy Loh
On 2015/03/09 21:30:40, rwlbuis wrote: > PTAL lgtm
5 years, 9 months ago (2015-03-10 06:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993713002/1
5 years, 9 months ago (2015-03-10 11:19:47 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:48:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191623

Powered by Google App Engine
This is Rietveld 408576698