[Download] Add an unittest of DownloadCommands class

[Download] Add an unittest of DownloadCommands class

BUG=465193
TEST=unittest passes
R=asanka@chromium.org

Committed: https://crrev.com/7a67c76dd70a14ec364c349a42e1029a625360fb
Cr-Commit-Position: refs/heads/master@{#320221}

[yoshiki, 2015-03-09 18:28:02]

yoshiki@chromium.org changed reviewers:
+ asanka@chromium.org

[yoshiki, 2015-03-09 18:28:31]

Asanka, PTAL. Thanks.

[asanka, 2015-03-09 19:02:20]

Thanks this looks mostly good.

I think that this sort of test would be easier to manage if there was a clear
mapping from <state of download, external state> to <expected outcome>. I.e.
what should the enabled/checked states be for an in-progress, active download?
What are the minimal expectations for invoking the Execute method for enabled
actions? This should be readily apparent from the tests.

https://codereview.chromium.org/993643002/diff/1/chrome/browser/download/down...
File chrome/browser/download/download_commands_unittest.cc (right):

https://codereview.chromium.org/993643002/diff/1/chrome/browser/download/down...
chrome/browser/download/download_commands_unittest.cc:77:
SetupDownloadItemDefaults();
Add a SetUp() function to DownloadCommandsTest and have it run
SetupDownloaditemDefaults().

[yoshiki, 2015-03-10 18:09:42]

Asanka, Thank you for giving comments. I spited (and rewrote) the tests as you
advised. Could you review the patch again?

[asanka, 2015-03-10 21:54:21]

Thanks! LGTM

[yoshiki, 2015-03-11 04:02:47]

Thank you for reviewing!

[yoshiki, 2015-03-11 04:02:52]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2015-03-11 04:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993643002/20001

[commit-bot: I haz the power, 2015-03-11 07:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 07:52:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2015-03-12 01:54:16]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-03-12 01:54:17]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/993643002/#ps40001 (title:
"fix test failure")

[commit-bot: I haz the power, 2015-03-12 01:54:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993643002/40001

[commit-bot: I haz the power, 2015-03-12 03:12:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-12 03:13:43]

Patchset 3 (id:??) landed as
https://crrev.com/7a67c76dd70a14ec364c349a42e1029a625360fb
Cr-Commit-Position: refs/heads/master@{#320221}