Issue 993613005: Stop pushing the value of 'default' to LoadableTextTrack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 993613005: Stop pushing the value of 'default' to LoadableTextTrack (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Stop pushing the value of 'default' to LoadableTextTrack This value is only used during track selection, and caching the value should have little impact since this is not a very performance-sensitive code-path. Simply check for existance of the attribute instead. This also works around an issue with ASAN and inline-capacity Vectors. BUG=464065 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191652

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	Source/core/html/HTMLTrackElement.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/track/LoadableTextTrack.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/html/track/LoadableTextTrack.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/html/track/TextTrack.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993613005/1

5 years, 9 months ago (2015-03-10 17:25:35 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 19:32:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191652

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages