Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 993613004: Fix ExceptionPorts.TaskAndThreadExceptionPorts under better compiler optimization (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix ExceptionPorts.TaskAndThreadExceptionPorts under better compiler optimization. Newer versions of clang (in this case, trunk r231191) can see through the pointless division by zero and optimize it away. This caused the test to hang in release mode. A 50ms timeout is added to each test to transform the hang into a failure. The test was split into 12 tests to provide better feedback and control. To fix the bug, the division by zero is replaced by __builtin_trap(). TEST=crashpad_util_test ExceptionPorts.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c4a8b32495b5d4d873c4b55999093daafffaa5b3

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -82 lines) Patch
M util/mach/exception_ports_test.cc View 1 9 chunks +112 lines, -82 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-10 13:31:43 UTC) #2
Robert Sesek
https://codereview.chromium.org/993613004/diff/1/util/mach/exception_ports_test.cc File util/mach/exception_ports_test.cc (right): https://codereview.chromium.org/993613004/diff/1/util/mach/exception_ports_test.cc#newcode497 util/mach/exception_ports_test.cc:497: TestExceptionPorts::kMainThreadCrashes); kOtherThreadCrashes https://codereview.chromium.org/993613004/diff/1/util/mach/exception_ports_test.cc#newcode546 util/mach/exception_ports_test.cc:546: TestExceptionPorts::kMainThreadCrashes); kOtherThreadCrashes https://codereview.chromium.org/993613004/diff/1/util/mach/exception_ports_test.cc#newcode572 util/mach/exception_ports_test.cc:572: TestExceptionPorts::kMainThreadCrashes); ...
5 years, 9 months ago (2015-03-10 14:53:49 UTC) #3
Mark Mentovai
Thanks, updated.
5 years, 9 months ago (2015-03-10 15:15:13 UTC) #4
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-10 15:15:38 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-10 15:16:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4a8b32495b5d4d873c4b55999093daafffaa5b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698