DescriptionFix ExceptionPorts.TaskAndThreadExceptionPorts under better compiler
optimization.
Newer versions of clang (in this case, trunk r231191) can see through
the pointless division by zero and optimize it away. This caused the
test to hang in release mode.
A 50ms timeout is added to each test to transform the hang into a
failure. The test was split into 12 tests to provide better feedback and
control.
To fix the bug, the division by zero is replaced by __builtin_trap().
TEST=crashpad_util_test ExceptionPorts.*
R=rsesek@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c4a8b32495b5d4d873c4b55999093daafffaa5b3
Patch Set 1 #
Total comments: 3
Patch Set 2 : Address review feedback #Messages
Total messages: 6 (1 generated)
|