Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: runtime/vm/message_handler.cc

Issue 993613002: Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message_handler.cc
diff --git a/runtime/vm/message_handler.cc b/runtime/vm/message_handler.cc
index 27641d054d22d211c62dbb63f16e6026d46df5e6..3188675c73d57d68e91455abf6723eb18d6fd837 100644
--- a/runtime/vm/message_handler.cc
+++ b/runtime/vm/message_handler.cc
@@ -102,10 +102,11 @@ void MessageHandler::PostMessage(Message* message, bool before_events) {
source_name = source_isolate->name();
}
OS::Print("[>] Posting message:\n"
+ "\tlen: %" Pd "\n"
"\tsource: %s\n"
"\tdest: %s\n"
"\tdest_port: %" Pd64 "\n",
- source_name, name(), message->dest_port());
+ message->len(), source_name, name(), message->dest_port());
}
Message::Priority saved_priority = message->priority();
@@ -146,12 +147,14 @@ bool MessageHandler::HandleMessages(bool allow_normal_messages,
Message::Priority min_priority = (allow_normal_messages && !paused()) ?
Message::kNormalPriority : Message::kOOBPriority;
Message* message = DequeueMessage(min_priority);
+ intptr_t message_len = message->len();
while (message != NULL) {
if (FLAG_trace_isolates) {
OS::Print("[<] Handling message:\n"
+ "\tlen: %" Pd "\n"
"\thandler: %s\n"
"\tport: %" Pd64 "\n",
- name(), message->dest_port());
+ message_len, name(), message->dest_port());
}
// Release the monitor_ temporarily while we handle the message.
@@ -164,9 +167,10 @@ bool MessageHandler::HandleMessages(bool allow_normal_messages,
monitor_.Enter();
if (FLAG_trace_isolates) {
OS::Print("[.] Message handled:\n"
+ "\tlen: %" Pd "\n"
"\thandler: %s\n"
"\tport: %" Pd64 "\n",
- name(), saved_dest_port);
+ message_len, name(), saved_dest_port);
}
if (!result) {
// If we hit an error, we're done processing messages.
« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698