runtime/vm/debugger.cc - Issue 993613002: Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 993613002: Implement 'print', 'up', 'down', and 'frame' commands in the Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 15289c79a1f92277c63ac46f2302feb35a5915ae..1834063e31316fd48cb132875c586747738b9aef 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -728,7 +728,10 @@ void ActivationFrame::VariableAt(intptr_t i,

ASSERT(i < desc_indices_.length());

intptr_t desc_index = desc_indices_[i];

ASSERT(name != NULL);

- *name ^= var_descriptors_.GetName(desc_index);

+ const String& tmp = String::Handle(var_descriptors_.GetName(desc_index));

+ *name ^= String::IdentifierPrettyName(tmp);

RawLocalVarDescriptors::VarInfo var_info;

var_descriptors_.GetInfo(desc_index, &var_info);

ASSERT(token_pos != NULL);

« no previous file with comments | « runtime/observatory/test/source_location_test.dart ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »