Use SkTMin and SkTMax for clamp/pin.

Use SkTMin and SkTMax for clamp/pin.

This changes SkScalarClampMax and SkScalarPin to use SkTMin and SkTMax.
This change allows compilers to more easily transform these operations
into fast max/min operarations as opposed to conditional branches.

Committed: https://skia.googlesource.com/skia/+/167eb17cd6654a0ab6f7c544441a0defa88e3827

[bungeman-skia, 2015-03-09 15:59:33]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2015-03-09 15:59:33]

Splitting this out of the larger CL at
https://codereview.chromium.org/977623002/ .

[bungeman-skia, 2015-03-09 15:59:53]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-03-09 16:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993593002/1

[commit-bot: I haz the power, 2015-03-09 16:00:03]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-09 22:00 UTC

[commit-bot: I haz the power, 2015-03-09 16:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 16:00:07]

Presubmit check for 993593002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[mtklein, 2015-03-09 17:06:02]

lgtm

[bungeman-skia, 2015-03-09 17:28:12]

https://codereview.chromium.org/993593002/diff/1/include/core/SkScalar.h
File include/core/SkScalar.h (right):

https://codereview.chromium.org/993593002/diff/1/include/core/SkScalar.h#newc...
include/core/SkScalar.h:173: x = SkTMax(x, SkIntToScalar(0));
Just wanted to point out that just '0' here doesn't work, since it's the wrong
type (SkTMin and SkTMax both take (T, T)).

[mtklein, 2015-03-09 17:34:41]

https://codereview.chromium.org/993593002/diff/1/include/core/SkScalar.h
File include/core/SkScalar.h (right):

https://codereview.chromium.org/993593002/diff/1/include/core/SkScalar.h#newc...
include/core/SkScalar.h:173: x = SkTMax(x, SkIntToScalar(0));
On 2015/03/09 17:28:11, bungeman1 wrote:
> Just wanted to point out that just '0' here doesn't work, since it's the wrong
> type (SkTMin and SkTMax both take (T, T)).

0.0f?

[bungeman-skia, 2015-03-09 17:57:53]

State the type, depend on auto conversion of constant.

[reed1, 2015-03-09 20:05:00]

nice lgtm

[bungeman-skia, 2015-03-09 20:33:08]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-03-09 20:33:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/993593002/#ps20001 (title:
"State type and auto convert constant.")

[commit-bot: I haz the power, 2015-03-09 20:34:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993593002/20001

[commit-bot: I haz the power, 2015-03-09 20:40:19]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/167eb17cd6654a0ab6f7c544441a0defa88e3827