Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 993543003: IDL: Support [NewObject] and [SameObject] extended attributes (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Support [NewObject] and [SameObject] extended attributes This patch only adds the names to the list of allowed extended attribute, so that having them in the IDL doesn't cause compilation errors. Using them has no effect on the generated code; we're allowing them so that IDL files can use the same syntax as specifications. BUG=462913 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jens Widell
PTAL I think implementing these as no-ops is the most reasonable approach.
5 years, 9 months ago (2015-03-09 11:56:35 UTC) #2
haraken
I'm wondering what the [NewObject] and [SameObject] are for. Is the Web IDL spec intending ...
5 years, 9 months ago (2015-03-09 23:26:42 UTC) #3
Jens Widell
On 2015/03/09 23:26:42, haraken wrote: > I'm wondering what the [NewObject] and [SameObject] are for. ...
5 years, 9 months ago (2015-03-10 07:17:51 UTC) #4
haraken
LGTM, because [NewObject] and [SameObject] are speced. (IMHO, [NewObject] and [SameObject] are not that meaningful ...
5 years, 9 months ago (2015-03-10 11:13:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993543003/1
5 years, 9 months ago (2015-03-10 11:19:49 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:32:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191621

Powered by Google App Engine
This is Rietveld 408576698