Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 993533003: Revert of Store the next serial number in the function cache rather than in the isolate. (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Store the next serial number in the function cache rather than in the isolate.Don't overwrite existi (patchset #4 id:60001 of https://codereview.chromium.org/988693003/) Reason for revert: This doesn't do what it's supposed to do. The problem seems to lie on the blink side, people aren't reusing their FunctionTemplates (or creating them when not necessary). Original issue's description: > Don't overwrite existing serial numbers on the function template, otherwise instantiating the function for a new context causes the serial number to bump. > > Committed: https://crrev.com/1e638c3610ec6938e5fb16c42018642195782fb2 > Cr-Commit-Position: refs/heads/master@{#27048} TBR=yangguo@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a9a362360441ab83227d4c84d3e147209999d56a Cr-Commit-Position: refs/heads/master@{#27067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
Created Revert of Store the next serial number in the function cache rather than in ...
5 years, 9 months ago (2015-03-09 10:53:29 UTC) #1
Yang
On 2015/03/09 10:53:29, Toon Verwaest wrote: > Created Revert of Store the next serial number ...
5 years, 9 months ago (2015-03-09 11:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993533003/1
5 years, 9 months ago (2015-03-09 12:29:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 12:30:08 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 12:30:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9a362360441ab83227d4c84d3e147209999d56a
Cr-Commit-Position: refs/heads/master@{#27067}

Powered by Google App Engine
This is Rietveld 408576698