Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 99353005: AVFoundation: Check selector when testing if max frame rate setting is supported. (Closed)

Created:
7 years ago by mcasas
Modified:
7 years ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

AVFoundation: Allow exceptions when checking if max frame rate setting is supported. Addressing some sporadic crashes, see http://crbug.com/327532, with "Selector not found" when trying to query the AVCaptureConnection if it supports setting max video frame rate, at [1]. Beyond that, this problem started affecting all non-HD cameras in Mac Os X < 10.9 -- see log in http://crbug.com/328096 --. This CL checks if the selector is recognised before attemping to use it. [1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/mac/video_capture_device_avfoundation_mac.mm&q=isvideomaxframe&sq=package:chromium&type=cs&l=174 BUG=288562, 327532, 328096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241056

Patch Set 1 #

Total comments: 1

Patch Set 2 : rsesek@ comments #

Total comments: 1

Patch Set 3 : rsesek@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M media/video/capture/mac/video_capture_device_avfoundation_mac.mm View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
mcasas
Hi tommi@ PTAL!
7 years ago (2013-12-16 10:53:37 UTC) #1
tommi (sloooow) - chröme
Have you verified that this fixes the problem? It would be good to get an ...
7 years ago (2013-12-16 11:52:41 UTC) #2
mcasas
rsesek@, can you PTAL? I've verified this fix in Debug configs both in Mavericks+MacBookAir+FaceTimeHD and ...
7 years ago (2013-12-16 12:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/99353005/1
7 years ago (2013-12-16 13:12:34 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=202997
7 years ago (2013-12-16 13:48:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/99353005/1
7 years ago (2013-12-16 14:12:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204728
7 years ago (2013-12-16 14:57:22 UTC) #7
Robert Sesek
This seems wrong. Why is that selector being sent in the first place?
7 years ago (2013-12-16 15:36:49 UTC) #8
Robert Sesek
https://codereview.chromium.org/99353005/diff/1/media/video/capture/mac/video_capture_device_avfoundation_mac.mm File media/video/capture/mac/video_capture_device_avfoundation_mac.mm (right): https://codereview.chromium.org/99353005/diff/1/media/video/capture/mac/video_capture_device_avfoundation_mac.mm#newcode175 media/video/capture/mac/video_capture_device_avfoundation_mac.mm:175: if ([captureConnection isVideoMaxFrameDurationSupported]) { Instead, if ([captureConnection respondsToSelector:@selector(isVideoMaxFrameDurationSupported] && ...
7 years ago (2013-12-16 15:41:35 UTC) #9
mcasas
rsesek@, PTAL!
7 years ago (2013-12-16 16:45:47 UTC) #10
Robert Sesek
LGTM You may need to do this for Min, too. https://codereview.chromium.org/99353005/diff/20001/media/video/capture/mac/video_capture_device_avfoundation_mac.mm File media/video/capture/mac/video_capture_device_avfoundation_mac.mm (right): https://codereview.chromium.org/99353005/diff/20001/media/video/capture/mac/video_capture_device_avfoundation_mac.mm#newcode11 ...
7 years ago (2013-12-16 17:20:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/99353005/50001
7 years ago (2013-12-16 17:28:08 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204933
7 years ago (2013-12-16 18:50:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/99353005/50001
7 years ago (2013-12-16 19:10:05 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205037
7 years ago (2013-12-16 20:54:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/99353005/50001
7 years ago (2013-12-16 21:20:07 UTC) #16
commit-bot: I haz the power
7 years ago (2013-12-16 23:02:51 UTC) #17
Message was sent while issue was closed.
Change committed as 241056

Powered by Google App Engine
This is Rietveld 408576698