Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993513009: Fix old space check in IsSlotInBlackObject. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix old space check in IsSlotInBlackObject. BUG= Committed: https://crrev.com/4f865389bcecdff6aa56512fab3a147507a95a51 Cr-Commit-Position: refs/heads/master@{#27090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
lgtm
5 years, 9 months ago (2015-03-10 09:13:32 UTC) #2
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-10 09:13:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993513009/1
5 years, 9 months ago (2015-03-10 09:14:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 09:49:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4f865389bcecdff6aa56512fab3a147507a95a51 Cr-Commit-Position: refs/heads/master@{#27090}
5 years, 9 months ago (2015-03-10 09:49:56 UTC) #7
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-10 11:54:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/987303003/ by hpayer@chromium.org.

The reason for reverting is: Breaks arm.debug..

Powered by Google App Engine
This is Rietveld 408576698