chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 993513006: Introduce ManagePasswordsState class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 993513006: Introduce ManagePasswordsState class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 0ead6565a6a0d48f70482bd8c8c3156630367f29..a74236395683b825e767c991ba83c50d5c779cfa 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -199,6 +199,8 @@ void ManagePasswordsBubbleModel::OnBubbleHidden() {

manage_passwords_ui_controller) {

// It's time to run the pending callback if it wasn't called in

// OnChooseCredentials().

+ // TODO(vasilii): remove this. It's not a bubble's problem because the

+ // controller is notified anyway about closed bubble.

manage_passwords_ui_controller->ChooseCredential(

autofill::PasswordForm(),

password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY);