Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 993513005: Log the runtime type of messages (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Log the runtime type of messages This makes is a little easier to investigate errors. R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/78aba252aeebad75e2f4616b6f1890e3208f4951

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M lib/src/report.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/codegen/expect/BenchmarkBase.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M test/codegen/expect/cascade.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/fieldtest.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/methods.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/codegen/expect/sunflower.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/types.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 9 months ago (2015-03-09 18:37:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 9 months ago (2015-03-09 18:38:09 UTC) #3
vsm
5 years, 9 months ago (2015-03-09 18:46:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
78aba252aeebad75e2f4616b6f1890e3208f4951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698