Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 993473002: [turbofan] Add support for inlining of builtins. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for inlining of builtins. We mark certain builtins for inlining, and those should always be inlined into optimized code (CrankShaft already handles it this way), so we should support that in TurboFan as well. Currently this mainly affects a certain set of Math functions, but once have the basics in place we can extend this to any kind of builtin/code stub/accessor. This adds a new flag --turbo_builtin_inlining (enabled by default), that forces the inliner to always inline builtins marked for inlining, but does not affect inlining of other functions (this is still controlled by the --turbo-inlining flag). BUG=v8:3952 LOG=n R=jarin@chromium.org Committed: https://crrev.com/25895aeeaf79918ebf9eecf1535e7a8e5bed9e97 Cr-Commit-Position: refs/heads/master@{#27059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M src/compiler.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 4 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-09 07:41:55 UTC) #1
Benedikt Meurer
Michi: FYI
5 years, 9 months ago (2015-03-09 07:58:39 UTC) #2
Jarin
looks good to me, but Michi might want to have a look at the massaging ...
5 years, 9 months ago (2015-03-09 08:03:57 UTC) #3
Jarin
On 2015/03/09 08:03:57, jarin wrote: > looks good to me, but Michi might want to ...
5 years, 9 months ago (2015-03-09 08:04:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/25895aeeaf79918ebf9eecf1535e7a8e5bed9e97 Cr-Commit-Position: refs/heads/master@{#27059}
5 years, 9 months ago (2015-03-09 08:05:52 UTC) #5
Benedikt Meurer
5 years, 9 months ago (2015-03-09 08:05:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25895aeeaf79918ebf9eecf1535e7a8e5bed9e97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698