Issue 99343006: Merge 237115 "Security fix for untrusted signin confirm dialog"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99343006: Merge 237115 "Security fix for untrusted signin confirm dialog" (Closed)

Created:
7 years ago by Roger Tawa OOO till Jul 10th

Modified:
7 years ago

Reviewers:
guohui

CC:
chromium-reviews, tim+watch_chromium.org, tfarina, rsimha+watch_chromium.org, haitaol+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1700/src/

Visibility:
Public.

More Reviews

Description

Merge 237115 "Security fix for untrusted signin confirm dialog" > Security fix for untrusted signin confirm dialog > > When the window associated with the confirm dialog is closed without user clicking 'ok got it', chrome starts sync with default settings. This could be exploited to sign a user's Chrome into an attacker's account, as reported in crbug 321940. > > BUG=321940 > > Review URL: https://codereview.chromium.org/79553004 TBR=guohui@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238138

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/one_click_signin_view_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/sync/one_click_signin_bubble_view_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages