Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993423002: Reland kiosk: Fix bailout shortcut not working. (Closed)

Created:
5 years, 9 months ago by xiyuan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland kiosk: Fix bailout shortcut not working. Explicitly enable WebUILoginView before launching kiosk so that the bailout shortcut key works. BUG=465561 Committed: https://crrev.com/71a202e756e5ae8842ea14f0f02d0cc31d4bad1f Cr-Commit-Position: refs/heads/master@{#320128}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xiyuan
WebUILoginDisplay::SetUIEnabled(true) has a side effect of going back to sign-in UI when user is not ...
5 years, 9 months ago (2015-03-11 18:40:02 UTC) #2
jennyz
lgtm
5 years, 9 months ago (2015-03-11 18:46:27 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 9 months ago (2015-03-11 19:16:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993423002/20001
5 years, 9 months ago (2015-03-11 19:38:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 19:50:37 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:51:20 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/71a202e756e5ae8842ea14f0f02d0cc31d4bad1f
Cr-Commit-Position: refs/heads/master@{#320128}

Powered by Google App Engine
This is Rietveld 408576698