Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: Source/devtools/front_end/elements/AnimationTimeline.js

Issue 993413004: Devtools Animations: Update transition timing on timeline interaction (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/AnimationTimeline.js
diff --git a/Source/devtools/front_end/elements/AnimationTimeline.js b/Source/devtools/front_end/elements/AnimationTimeline.js
index 56eb22b64b19cb55e394e2facaf6378f597d01c9..818241e2937b5145d0c038575cac9bc58c25fb6a 100644
--- a/Source/devtools/front_end/elements/AnimationTimeline.js
+++ b/Source/devtools/front_end/elements/AnimationTimeline.js
@@ -786,11 +786,10 @@ WebInspector.AnimationUI.prototype = {
var duration = this._duration();
this._setDelay(delay);
this._setDuration(duration);
- // FIXME: Transition timing updates currently not supported
- if (this._animation.type() == "WebAnimation") {
+ if (this._animation.type() !== "CSSAnimation") {
dgozman 2015/03/30 10:38:58 What about CSSAnimation? Should you leave the FIXM
samli 2015/03/30 23:14:17 No, CSS animations are already supported in http:/
var target = WebInspector.targetManager.mainTarget();
if (target)
- target.animationAgent().setTiming(this._animation.id(), duration, delay);
+ target.animationAgent().setTiming(this._animation.id(), duration, delay, this._animation.type() === "CSSTransition");
}
}

Powered by Google App Engine
This is Rietveld 408576698