[strong] Cleanup and fix test (declaration-after-use.js).

[strong] Cleanup and fix test (declaration-after-use.js).

Cleanup: Better helpers, unified line splitting. Also asserting that without
strong mode, the snippets don't produce errors.

Fix: The eval related tests were wrong (we didn't make sure that the error
thrown comes from strong scoping and is not a normal runtime error).

BUG=v8:3956
LOG=N

Committed: https://crrev.com/44c8c1bcfe7b77f7c50273b2e754b75a909faac9
Cr-Commit-Position: refs/heads/master@{#27153}

[marja, 2015-03-11 15:29:13]

marja@chromium.org changed reviewers:
+ rossberg@chromium.org

[marja, 2015-03-11 15:29:23]

rossberg, ptal

[arv (Not doing code reviews), 2015-03-11 18:31:31]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-03-11 18:31:32]

LGTM

https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declarat...
File test/mjsunit/strong/declaration-after-use.js (right):

https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declarat...
test/mjsunit/strong/declaration-after-use.js:150: "class COuter {\n" +
These can use template literals if you want.

assertThrowsHelper(`
    class COuter {
      m() {
        class CInner {
          [({ m() { CInner; return 'A'; } }).m()]() {
            return 'B';
          }
        }
      }
   }`);

[rossberg, 2015-03-12 09:02:35]

lgtm

[marja, 2015-03-12 10:30:38]

t

https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declarat...
File test/mjsunit/strong/declaration-after-use.js (right):

https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declarat...
test/mjsunit/strong/declaration-after-use.js:150: "class COuter {\n" +
On 2015/03/11 18:31:32, arv wrote:
> These can use template literals if you want.
> 
> assertThrowsHelper(`
>     class COuter {
>       m() {
>         class CInner {
>           [({ m() { CInner; return 'A'; } }).m()]() {
>             return 'B';
>           }
>         }
>       }
>    }`);

Done.

[marja, 2015-03-12 10:30:41]

The CQ bit was checked by marja@chromium.org

[marja, 2015-03-12 10:30:41]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/993393002/#ps20001 (title:
"template lits")

[commit-bot: I haz the power, 2015-03-12 10:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993393002/20001

[commit-bot: I haz the power, 2015-03-12 10:52:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-12 10:52:16]

Patchset 2 (id:??) landed as
https://crrev.com/44c8c1bcfe7b77f7c50273b2e754b75a909faac9
Cr-Commit-Position: refs/heads/master@{#27153}