Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 993393002: [strong] Cleanup and fix test (declaration-after-use.js). (Closed)

Created:
5 years, 9 months ago by marja
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Cleanup and fix test (declaration-after-use.js). Cleanup: Better helpers, unified line splitting. Also asserting that without strong mode, the snippets don't produce errors. Fix: The eval related tests were wrong (we didn't make sure that the error thrown comes from strong scoping and is not a normal runtime error). BUG=v8:3956 LOG=N Committed: https://crrev.com/44c8c1bcfe7b77f7c50273b2e754b75a909faac9 Cr-Commit-Position: refs/heads/master@{#27153}

Patch Set 1 #

Total comments: 2

Patch Set 2 : template lits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -122 lines) Patch
M test/mjsunit/strong/declaration-after-use.js View 1 2 chunks +102 lines, -122 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
marja
rossberg, ptal
5 years, 9 months ago (2015-03-11 15:29:23 UTC) #2
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declaration-after-use.js File test/mjsunit/strong/declaration-after-use.js (right): https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declaration-after-use.js#newcode150 test/mjsunit/strong/declaration-after-use.js:150: "class COuter {\n" + These can use template ...
5 years, 9 months ago (2015-03-11 18:31:32 UTC) #4
rossberg
lgtm
5 years, 9 months ago (2015-03-12 09:02:35 UTC) #5
marja
t https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declaration-after-use.js File test/mjsunit/strong/declaration-after-use.js (right): https://codereview.chromium.org/993393002/diff/1/test/mjsunit/strong/declaration-after-use.js#newcode150 test/mjsunit/strong/declaration-after-use.js:150: "class COuter {\n" + On 2015/03/11 18:31:32, arv ...
5 years, 9 months ago (2015-03-12 10:30:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993393002/20001
5 years, 9 months ago (2015-03-12 10:30:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-12 10:52:09 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 10:52:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44c8c1bcfe7b77f7c50273b2e754b75a909faac9
Cr-Commit-Position: refs/heads/master@{#27153}

Powered by Google App Engine
This is Rietveld 408576698