Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 993363002: GrGLInterface: Add support for NV_framebuffer_mixed_samples (Closed)

Created:
5 years, 9 months ago by vbuzinov
Modified:
5 years, 8 months ago
Reviewers:
Chris Dalton, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrGLInterface: Add support for NV_framebuffer_mixed_samples Import glCoverageModulation if NV_framebuffer_mixed samples is available BUG=skia:3177 Committed: https://skia.googlesource.com/skia/+/08b4d29a0a29badc15129c9bc7ee8352bc75278d

Patch Set 1 #

Patch Set 2 : Rebase and missing validation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 3 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vbuzinov
Hi Brian, could you take a look? This is patch 1 of 2 of NV_framebuffer_mixed_samples ...
5 years, 9 months ago (2015-03-24 06:33:37 UTC) #2
bsalomon
On 2015/03/24 06:33:37, vbuzinov wrote: > Hi Brian, could you take a look? This is ...
5 years, 9 months ago (2015-03-24 15:28:19 UTC) #3
Chris Dalton
Should we add some validation code to the end of GrGLInterface::validate? if (fExtensions.has("GL_NV_framebuffer_mixed_samples")) { if ...
5 years, 9 months ago (2015-03-25 22:32:33 UTC) #5
bsalomon
On 2015/03/25 22:32:33, Chris Dalton wrote: > Should we add some validation code to the ...
5 years, 9 months ago (2015-03-26 17:14:31 UTC) #6
vbuzinov
Missed the validation comment, sorry, fixing that + rebasing
5 years, 8 months ago (2015-04-01 13:11:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993363002/20001
5 years, 8 months ago (2015-04-01 13:22:06 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 13:29:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08b4d29a0a29badc15129c9bc7ee8352bc75278d

Powered by Google App Engine
This is Rietveld 408576698