Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 99333017: IDL compiler: simplify type conversion in Event Constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix layout test result (error text) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/Dictionary.cpp
diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp
index 708bb709c0e63e8963f48a31150069761ef866bd..6431d5b1738b6d29f78cd3cda4b5d25681eb998f 100644
--- a/Source/bindings/v8/Dictionary.cpp
+++ b/Source/bindings/v8/Dictionary.cpp
@@ -743,41 +743,19 @@ void Dictionary::ConversionContext::resetPerPropertyContext()
m_dirty = false;
m_isNullable = false;
m_propertyTypeName = "";
- m_numberConversion = NormalConversion;
}
}
-Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(bool isNullable, IntegerConversionConfiguration conversion, const String& typeName)
+Dictionary::ConversionContext& Dictionary::ConversionContext::setConversionType(const String& typeName, bool isNullable)
{
ASSERT(!m_dirty);
m_dirty = true;
m_isNullable = isNullable;
m_propertyTypeName = typeName;
- m_numberConversion = conversion;
return *this;
}
-Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(bool isNullable, const String& typeName)
-{
- return withAttributes(isNullable, NormalConversion, typeName);
-}
-
-Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(bool isNullable, IntegerConversionConfiguration conversion)
-{
- return withAttributes(isNullable, conversion, "");
-}
-
-Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(const String& typeName)
-{
- return withAttributes(false, NormalConversion, typeName);
-}
-
-Dictionary::ConversionContext& Dictionary::ConversionContext::withAttributes(bool isNullable)
-{
- return withAttributes(isNullable, NormalConversion, "");
-}
-
void Dictionary::ConversionContext::throwTypeError(const String& detail)
{
if (forConstructor()) {
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698