IDL compiler: simplify type conversion in Event Constructor

Source/bindings/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 101 matching lines @@
 
         const String& interfaceName() const { return m_interfaceName; }
         const String& methodName() const { return m_methodName; }
         bool forConstructor() const { return m_methodName.isEmpty(); }
         ExceptionState& exceptionState() const { return m_exceptionState; }
 
         bool isNullable() const { return m_isNullable; }
         String typeName() const { return m_propertyTypeName; }
         IntegerConversionConfiguration numberConversion() const { return m_numberConversion; }
 
-        ConversionContext& withAttributes(bool, IntegerConversionConfiguration, const String&);
-        ConversionContext& withAttributes(bool, IntegerConversionConfiguration);
-        ConversionContext& withAttributes(bool, const String&);
-        ConversionContext& withAttributes(bool);
-        ConversionContext& withAttributes(const String&);
+        ConversionContext& conversionType(bool, IntegerConversionConfiguration, const String&);

[haraken, 2013/12/11 08:26:23]

I would rename it to setConversionType and reorder the parameters like:

  setConversionType(const String&, bool, IntegerConversionConfiguration)

since the type parameter is always necessary.

[Nils Barth (inactive), 2013/12/11 08:51:31]

Done (and removed the integer conversion);
that's clearer, as it's (type, isNullable): basic, auxiliary.

 
         void throwTypeError(const String& detail);
 
         void resetPerPropertyContext();
 
     private:
         const String m_interfaceName;
         const String m_methodName;
         ExceptionState& m_exceptionState;
         bool m_dirty;
@@ skipping 189 matching lines @@
             context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does not have " + (context.typeName().isEmpty() ? String("the expected type.") : ("a " + context.typeName() + " type."))));
             return false;
         }
     }
     return true;
 }
 
 }
 
 #endif // Dictionary_h