Source/core/loader/ImageLoader.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/ImageLoader.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/ImageLoader.cpp

diff --git a/Source/core/loader/ImageLoader.cpp b/Source/core/loader/ImageLoader.cpp

index 5c3768aaebb40867db3fc7805762c4e8c81c19c2..a8177ba48d59bf7fe79cc7d41c22cdbe68588f9c 100644

--- a/Source/core/loader/ImageLoader.cpp

+++ b/Source/core/loader/ImageLoader.cpp

@@ -157,7 +157,7 @@ void ImageLoader::updateFromElement()

if (!attr.isNull() && !stripLeadingAndTrailingHTMLSpaces(attr).isEmpty()) {

FetchRequest request(ResourceRequest(document.completeURL(sourceURI(attr))), element()->localName());

- String crossOriginMode = m_element->fastGetAttribute(HTMLNames::crossoriginAttr);

+ AtomicString crossOriginMode = m_element->fastGetAttribute(HTMLNames::crossoriginAttr);

if (!crossOriginMode.isNull()) {

StoredCredentials allowCredentials = equalIgnoringCase(crossOriginMode, "use-credentials") ? AllowStoredCredentials : DoNotAllowStoredCredentials;

updateRequestForAccessControl(request.mutableResourceRequest(), document.securityOrigin(), allowCredentials);

« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/core/loader/TextResourceDecoderBuilder.cpp » ('j') | no next file with comments »